Dinesh Purushothamacharya

Results 11 comments of Dinesh Purushothamacharya

@donraab - I'd like to work on this. Can you please assign it to me?

Hello @donraab, So far I understand that I need to update orderedPrimitiveIterable.stg file like below. correct me if am wrong. ``` default MutableStack toStack() { return } ``` I have...

Hello @donraab , I have created the below PR [1] for this issue. Could you please review it ? [1] : https://github.com/eclipse/eclipse-collections/pull/1068

@donraab I have updated the project with all the review fixes and unit tests for the changes. Please do review it and let me know if any more changes required...

> Hi @DineshPurushothamacharya, I'd like to help get this PR reviewed and merged. There are a couple of changes to start with since this PR has been open for a...

> Hi @DineshPurushothamacharya, looks like you have some actual issues to fix reported by the checkstyle build. Also, the EclipseFdn ECA check is failing. Do you have a signed ECA...

@donraab , @prathasirisha could you please review this PR? I would like to close this one.

> Thank you for the contribution @DineshPurushothamacharya ! I have a couple minor changes requested and after that I will approve and merge. @donraab Thanks for pointing the mistakes. I...

Hello @donraab could you please approve and merge this PR?

Hello @donraab, I have fixed the review comments as per your suggestions. Can you please review it and merge this PR?