DimitrisJim
DimitrisJim
yup, hence why we need a good example. I can't tell what is misbehaving in Jordan's example since I can't run it.
do we have any updates on the state of this PR? It's been sorta stale for 3 weeks now and we should try and get your work through soon if...
ah, sure, I can pick this up and get it through with @MegasKomnenos. Parser is definitely a more pressing issue so you can give as much attention there as needed....
> That's one of the flaky tests. Dunno if its flaky-ness here, triggering re-runs hasn't helped.
@youknowone has already opened a PR upstream for this (and so have others, I think there's three PRs open for this atm). It seems LALRPOP is also used in rustup...
> this repo is where the issue might belong It definitely is, thanks for reporting! We just recently bumped to using 3.11 so some things aren't here yet. Adding these...
Pasting the comment (https://github.com/RustPython/RustPython/pull/4592#pullrequestreview-1318321535) here too for anyone else who might need it: You can use the following command to test your changes locally (in a manner similar to RustPython's...
wow, this makes *a lot* of tests pass :smile: The following tests in `test_compile` can be marked as passing (i.e remove the `# TODO: RUSTPYTHON` comment and the `expectedFailure` decorator...
Heya @howjmay, if there's confusion on how to do it or you don't have enough time to do so let me know and I'll fix the tests as needed.
your previous commit (https://github.com/RustPython/RustPython/commit/c80802daa262366e5d7007adc7b1b1254969179b) was perfectly fine here! Like @fanninpm mentions, just go through the tests in `test_compile` and remove the decorators marking the functions as failing. If the stack...