DimitrisJim

Results 111 comments of DimitrisJim

There's a couple of tests passing in `test_string_literals.py` that you need to tweak. `test_eval_bytes_normal`, `test_eval_bytes_raw`, `test_eval_str_normal`, `test_eval_str_raw`, `test_eval_str_u` all now succeed. You should open that file and remove the decorators...

@branai, @yt2b has been opening issues and sending a PR at the same time so we'd have to get the ok from them! 🙂

There's another `eval` error if you want to tackle it @yt2b, it involves a custom locals object passed as the `locals` argument that raises something else than `KeyError` (see the...

Thanks! Message also gets printed even if `-q` is not passed, i.e we don't check if `stdin` is from a pipe or connected to a terminal. The correct solution involves...

Surprised nothing tested for this, we should add a test for this in `extra_tests/snippets/stdlib_binascii`.

Hm, not sure how this plays with freezing. You can get pip with `--install-pip get-pip` for now though, since that grabs it from bootstrap.pypa.io.

could you add the code snippet supplied in the issue as a test case in `extra_tests/snippets`? there's already be a file for lists (`extra_tests/snippets/builtin_list.py`), you could just add the snippet...

also, this does actually fix one of the tests I mentioned in the issue, if you remove the skip decorator from `test_count_index_remove_crashes` it should pass just fine.

Nice find. `ast` is not initialized here (i.e, if you `import ast` before running this, it works fine). Seems we also need to initialize `ast` earlier (it exists in `sys.modules`...

Note to anyone wanting to tackle this, test similar to this exist in [`test_equal_operator_modifying_operand`](https://github.com/RustPython/RustPython/blob/77e5d0c8eda0c94700c48bd239021094c7fca964/Lib/test/test_list.py#L168) and [`test_count_index_remove_crashes`](https://github.com/RustPython/RustPython/blob/77e5d0c8eda0c94700c48bd239021094c7fca964/Lib/test/test_list.py#L202) of `test_list`.