Brian Runnells

Results 28 comments of Brian Runnells

Going to whip something up for this soon. I initially set out to create a demo that required authentication with github's api, but that seems like overkill to be honest...

I wonder if we should use ember-cli-addon-doc at this point instead of the bespoke thing I got started and didn't really continue with

The injection is tested at the adapter level [here](https://github.com/elwayman02/ember-data-github/blob/194735305796d694259e19df488b7e1954067a75/tests/unit/adapters/github-test.js#L31), I wonder if it matters at all to also test in acceptance tests?

Once https://github.com/elwayman02/ember-data-github/pull/140 lands this model will exist and it can be wired up to the tree model as well

Looking at this and https://github.com/elwayman02/ember-data-github/issues/136 some more I'm not sure that Files or Directories are actually models that relate to trees. The current logic pulls the path and sha out...

As a comparison, the files array that comes back from a [single commit](https://developer.github.com/v3/repos/commits/#get-a-single-commit) makes sense as a model but does not match anything that comes along with trees ``` "files":...

Or we could leave it as is and let the serializer do the work here 🤷‍♂️

In this case I think github is being consistent, I'm just not sure what this addon was trying to accomplish with how it has things setup. In any event, the...

There are a _ton_ of apis not yet supported, so an issue per endpoint might be overwhelming. Perhaps one master issue?

Related to https://github.com/elwayman02/ember-data-github/issues/144