ember-data-github icon indicating copy to clipboard operation
ember-data-github copied to clipboard

Published 20 hours ago • verified publisher icon elwayman02

DRY up auth testing

Open Dhaulagiri opened this issue 7 years ago • 3 comments

Currently we have a lot of repeated code in acceptance tests confirm the auth token is sent with requests. This seems like the wrong level to be testing this as the acceptances are really just confirming that injecting the token into the adapter works which could be tested at a lower level once?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Dhaulagiri avatar Feb 12 '18 22:02 Dhaulagiri

Agreed, seems better to just test the inject in a single place

elwayman02 avatar Feb 13 '18 01:02 elwayman02

The injection is tested at the adapter level here, I wonder if it matters at all to also test in acceptance tests?

Dhaulagiri avatar Mar 20 '18 17:03 Dhaulagiri

Probably not.

elwayman02 avatar Mar 21 '18 18:03 elwayman02