Devashishbasu

Results 57 comments of Devashishbasu

Hi @rohanKanojia this branch is failing because of code coverage minimum should be 80% but mine is 79.3% , so will it work? or do i need to modify the...

Hii @rohanKanojia i was little confused regarding the encoded string thats why i added slightly different validation for digest length. Could you please review it? will this validation work or...

> @Devashishbasu : Could you please rebase this branch against master? Done ...could you please review?

Hi @rohanKanojia i have a doubt, is IMAGE_NAME_REGEXP = Pattern.compile(NAME_COMPONENT_REGEXP + "(?:(?:/" + NAME_COMPONENT_REGEXP + ")+)?"); correct? because i can see an extra component "domainregexp" in its reference https://github.com/docker/docker/blob/04da4041757370fb6f85510c8977c5a18ddae380/vendor/github.com/docker/distribution/reference/regexp.go#L53 NameRegexp...

> @Devashishbasu : I think this regex only validates the name portion. Could you please check it by setting a breakpoint in `doValidate()` method and checking if `image` actually contains...

@rohanKanojia i have added this code for reading imagePullSecrets in PodTemplateHandler is it okay or i have to modify it? or do i have to add test cases? ```java public...

> In order to complete this issue, you need to do this: > > 1. Add field `List imagePullSecrets` in ControllerResourceConfig > 2. Modify ControllerResourceConfigTest to test newly added field...

Hi @rohanKanojia, I have made all the changes ..how do I test these changes??

> @Devashishbasu : Unit tests added to verify this change should pass. > > You can also verify by going to any demo project in `quickstarts/maven/` . > > *...