Devashishbasu

Results 57 comments of Devashishbasu

Hi @rohanKanojia ...unit tests added to verify my changes have passed and when i am building hello-world from quickstarts/maven using mvn clean install its showing build success ...but when i...

please assign this issue to me

> I think @Devashishbasu has already contributed to jkube in [jkubeio/jkube-images#39](https://github.com/jkubeio/jkube-images/pull/39) . > > @Devashishbasu : Have you started any work on this? if not, shall I unassign you from...

> @Devashishbasu : I've created two good first issues. Could you please check if you can pick any of those? Thankyou...I can do both please assign both to me

> @Devashishbasu Please check CI jobs and fix failures. i have tried Another option to terminate the thread in callOnDetachFromWindow...could you please review...build was successful in local

> @Devashishbasu Please squash your commits to one as Robolectric prefers single commit PR for many occasions. Done

> Hi @Devashishbasu , > > Thanks for this PR. I believe the problem is that GLSurfaceView starts a thread when `setRenderer` is called: > > https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/opengl/java/android/opengl/GLSurfaceView.java;l=360 > > This...

Hi @hoisie , could you please review the test? and in which folder do i need to place the test? import android.app.Activity; import android.opengl.GLSurfaceView; import android.os.Bundle; import androidx.test.ext.junit.runners.AndroidJUnit4; import org.junit.Test;...

Hi @utzcoz @MGaetan89 ...how can i retrieve the GLThread associated with GLSurfaceView?

> @Devashishbasu I think you can use reflector or common reflection code to retrieve `mGLThread` from a `GLSurfaceView` instance. Hi, @utzcoz could you please review if the code added by...