DS

Results 474 comments of DS

Thanks for the review!

I've disabled doppler effect for now. We should later add an API for the server to control doppler factor and speed of sound.

Note: It looks like I had some misconception about pitch. I thought pitch would change the pitch and resample the sound, so that the playback speed is the same as...

Resolved comments and rebased.

Thanks for re-review! Addressed comments. (And did a trivial rebase.)

Rebased (+ 2 commits). (The now missing `util/Optional.h` would've failed silently FYI. Might be worth re-running CI on some other PRs.)

Looked a last time over it, and removed some trivial changes left over from a rebase. Should be fine.