Juho Teperi

Results 298 comments of Juho Teperi

Pattern/RegExp class schema was added here: https://github.com/metosin/malli/pull/68/files But I don't have idea what it was supposed to do.

Ok, it is for cases like `(m/validate #"foo" foo)`. This finds the class-schema implementation because Schema lookup will take `type` (`class`) of the schema value if a Schema isn't found...

Perhaps. The use case here was to have a RegExp instance as a value. `(m/validate [Pattern] #"foo")` There doesn't seem to be any way to validate the value is a...

Currently blocked as `decode` can't access current Muuntaja instance and the request.

Trying to find my notes about this... hmm. I think I was a bit unhappy `-read-values` implementation for `JsonParser`, as it needs to move the parser token to a specific...

@bsless The last test cases shows the use case for the parser. To read and array lazily from a JSON stream, which is not an top level array, user needs...

@bsless If you have idea how to clean up the implementation, go ahead. Maybe the problem I had was that parser `.readValuesAs` doesn't handle that array start element? The parser...

Boilerplate on the library code isn't a problem. Macros can make namespace load times much worse and make it harder to understand the code.

Is the `read-values` for just reading e.g. top level Array elements? I recently implemented following example, where I used `readTree` to get one property from top level object, and then...

Yeah, that makes sense. I'll try to look a bit more into case 2, if there is still something that will be shared with this case. Before introducing new API...