Juho Teperi
Juho Teperi
The clojure code here already implements unit tests: https://github.com/clojure-vim/clojure.vim/blob/master/clj/src/vim_clojure_static/test.clj https://github.com/clojure-vim/clojure.vim/blob/master/clj/test/vim_clojure_static/indent_test.clj We should setup CI to run these.
Github actions configured in #4
[`g:clojure_align_subforms`](https://github.com/clojure-vim/clojure.vim#gclojure_align_subforms) option controls whether to indent function calls with one (tonsky's post) or two spaces ("emacs"/clojure-style-guide). The first, two spaces, is the default. If you haven't changed the option, check...
For Reagent, I likely wouldn't add a such feature. Reagent now has a special handling for React `dangerouslySetInnerHTML` property that only allows values tagged with a specific type. This is...
This could be also interesting for frontend use, to optimize the artifact size (#540) because the Trie implementation generates quite a lot of JS code and the performance doesn't matter...
I don't see a way to improve this. `:class` isn't a special property for Reagent components (`[function-name {props ...}]` so we can't automatically coerce these values to strings. Currently it...
We only convert `:class` to `:classNames` for HTML elements, like `:span` etc. From your example it wasn't obvious to me in which step the additional conversion should happen. We to...
Fixing for email type seems simple enough. Related: https://github.com/reagent-project/reagent/issues/504 Removing the rAF scheduling would remove the need for input workaround, but it would also be a big breaking change in...
Update to previous: fixing email isn't any simpler than other cases, browser doesn't provide the necessary Selection API methods for those inputs.
I'm closing this issue and combining all controlled input notes into https://github.com/reagent-project/reagent/issues/619.