Juho Teperi

Results 298 comments of Juho Teperi

While this is very simple change, I'd rather not merge this unless there are good reason why this is needed. Often the warnings affect functionality and they should always be...

@myguidingstar `resources` would be in `:resources-paths` meaning that boot-reload will never see the `resources` part of the path. Also, `:asset-path` option was already added and I'm thinking it's good idea...

Still managed to reproduce this. ```clj (include-css "css/main.css") (include-css "css/css/main.css") ```

Hmm, I am unable to reproduce this.

Can you try if you can reproduce this with https://github.com/Deraen/saapas, this is how I tested this: ``` ❯ boot repl boot.user=> (boot (dev)) Starting reload server on ws://localhost:45105 Writing boot_cljs_repl.cljs......

Yes, it was reverted on purpose. Using schema-value proved too unpredictable and broke existing code: https://github.com/metosin/schema-tools/commit/240f8a5f973d4f6b6036aebcbf110c04909bd65d

We are interested in finding a way to support this. Ideas welcome. Some ideas here: https://github.com/metosin/schema-tools/issues/8#issuecomment-199649328

Perhaps. I think `-value` postfix doesn't clearly indicate that Schema values would be walked over all along the path. Maybe `-values` is better?

@obeah It is also somewhat unpredictable with recursive: ``` clj (get-in {:a {:b (s/recursive Foo)}} [:a :b]) ;; Foo ;; or (s/recursive Foo) ? ```

Partially fixed by https://github.com/adzerk-oss/boot-reload/commit/3478268491efe85cacf955d6a4a11a0e64949054