Juho Teperi
Juho Teperi
77.8KB with React and 42.8KB with Preact.
I'm open to protocol or something similar. It means we'd have to break things by removing requires on React and user would need to require namespace providing React implementation and...
Related: #48 #198
Compiler protocol will allow customizing how Hiccup keywords are converted to elements, that can be useful in this case: https://github.com/reagent-project/reagent/blob/master/src/reagent/impl/template.cljs#L307
What kind of problems did you encounter and where? Existing behaviour should work in the most common case, where `href` return value is used for anchor `href` attribute: `Item 2`...
I tested this locally on on examples/frontend, using the same url I mentioned in my previous comment. The index view contains buttons "item 3" and "replace state item 4" which...
> Thanks for the fix ! Any idea of when this could be merged ? It doesn't work yet, and when I worked on this previously I was out of...
No, the implementation doesn't work with `reset-vals!` or `swap-vals!`. I hadn't really noticed those methods though they were implemented in September 2017. The implementation wouldn't be hard, for JVM Clojure...
Lets keep this open so that the explanation is easier to find, if someone else stumbles upon this. And also to help me remember to look into checking if Cljs...
While other points are probably true, I doubt js-cookie is smaller. In general Closure libraries result in smaller result because Closure compiler can do dead code elimination and inlining etc....