Davis Vaughan

Results 770 comments of Davis Vaughan

You have a number of target platforms you haven't specified the runner for, those are trying to use ubuntu 20.04 https://github.com/andrewdavidmackenzie/pigg/blob/73b1bf8c39280aaa532f57ec3a4d45d64dd1a8ab/dist-workspace.toml#L15 You can see them here The linux ones are...

IIUC it's for all the individual steps in the `release.yml` itself, like the `plan:` step here https://github.com/andrewdavidmackenzie/pigg/blob/73b1bf8c39280aaa532f57ec3a4d45d64dd1a8ab/.github/workflows/release.yml#L50 and the `host:` step here: https://github.com/andrewdavidmackenzie/pigg/blob/73b1bf8c39280aaa532f57ec3a4d45d64dd1a8ab/.github/workflows/release.yml#L217-L226 But I don't think it affects your...

Or `use_tidy_style()` is removed entirely, I'm not sure, but what you suggest also sounds reasonable

We think this is a styler related issue, and the formatting world for R in Positron is about to change enough that we feel we can close this one, but...

I'm actually not sure we could do this since for ALTREP vectors we wouldn't be able to give out a reference to some existing place in an underlying vector.

Relevant commits. Seems like it happens in `R CMD check --as-cran` in R-devel now. That's a good move on R core's part I think. https://github.com/wch/r-source/commit/2b3b7b46256f8a864310e1ff386b72e12db9ce75 https://github.com/wch/r-source/commit/5dc1df18a0eab3cc2eb52eb1a2d8608b4809c5d2

You seem to have installed R with brew. Did you do `brew install r`? If so, you should uninstall that and instead do `brew install --cask r`, as otherwise things...

See also https://github.com/tidyverse/tidyverse/issues/154#issuecomment-431373768 😆

I don't currently have the resources to spend much time on cpp11, but I don't love vendoring in general because it doesn't _actually_ 100% insulate you from cpp11 changes. Previous...

Does https://github.com/igraph/rigraph/blob/main/.github/workflows/style/action.yml actually error if there are any changed files that need formatting? I didn't think `git status` returns an exit code, I thought you'd need `git diff --exit-code`