Davis Vaughan comments

Results 783 comments of


                                            Davis Vaughan

Replace Rcpp dependency with cpp11

In Rcpp the guard for `VECTOR_PTR_RO` was previously set incorrectly. It has been fixed already in cran Rcpp of 1.0.13-1 https://github.com/RcppCore/Rcpp/commit/3ae789b8c138c44dbbed2ad922aa589fd299f596

upper bound too low for limit in fredr_category_series()

The limit is set by fred actually https://fred.stlouisfed.org/docs/api/fred/category_series.html#limit The intention is that you also use `offset` to "paginate" your way through multiple pages of data so it doesn't have to...

upper bound too low for limit in fredr_category_series()

It might be quite an undertaking, but switching to httr2 would allow fredr to use `req_perform_iterative()` to ease internal handling of this case https://github.com/r-lib/httr2/blob/824f142f048489d698673c4d2ada149b4e4c80c7/R/iterate.R#L6

`full_seq.numeric()` should set `finite = TRUE`

A few other edge cases to fix ```r > full_seq(c(1, NA, 2), 1) Error in if (any(((x - rng[1])%%period > tol) & (period - (x - rng[1])%%period > : missing...

Use `seq2()` to correctly compute indices

Actions failures look related to some other snapshot tests, not this

Add new `str_dedent` function

Like @lionel-, I think I am also surprised by the trailing `\n` here ``` r library(stringr) library(glue) glue_chr [1] "Line 1\nLine 2\nLine 3\n" glue_chr(" Line 1 Line 2 Line 3...

Frontend should break up multiline selections that get sent to Console (by expression or by `\n`)

I have determined the exact number of characters it fails on is suspiciously 4096 (or 2048 * 2, or 1024 * 4). Regardless, it is a suspicious number. Here is...

Frontend should break up multiline selections that get sent to Console (by expression or by `\n`)

Oh hello there: ``` [R] 2023-09-27T16:54:10.946936000Z [ark-unknown] INFO crates/ark/src/interface.rs:728: Error: input too large for buffer. ``` https://github.com/posit-dev/amalthea/blob/b3177e04ed54829eca385a597c89f37581fd17dc/crates/ark/src/interface.rs#L725-L730

Frontend should break up multiline selections that get sent to Console (by expression or by `\n`)

So it seems like we are actually refusing to send all of that input to R by not copying it over to R's read-console buffer, but then something freaks out...

Frontend should break up multiline selections that get sent to Console (by expression or by `\n`)

Ok maybe I didn't find the right place in the source, but it definitely seems like if you highlight a selection and send the selection to the console, then RStudio...