David Spickett
David Spickett
Apologies, I merged this without an approval, I got mixed up with the other 2 patches in the stack. But I think we had a decent consensus anyway? It's an...
Fixed by https://github.com/llvm/llvm-project/commit/6a12b43ac00096976a886bd6d3a1b70a804d09ca.
> It also looks like a coworker's libc change went through without issue: This build must have been done before the first land or while this was reverted, I don't...
>Thats what I need suggestions and inputs what changes we can accommodate to better support the DWARF64. Start by looking at the main differences DWARF64 has. Write DWARF64 specific tests...
Clang only supports DWARF64 for ELF: ``` def gdwarf64 : Flag, Group, Visibility, HelpText, MarshallingInfoFlag; ``` So the existing Linux bots could run these tests. You can check the test...
Assuming there is not a lot more work to be done for DWARF64, this needs a release note - https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb. You can do that in this PR or a follow...
This has approvals already and looks good to me, do you need someone to merge it?
Please go ahead and merge this, or I can do so for you if you're happy with it.
The above result is a flaky text, the next build was green so you can ignore it.
@nickdesaulniers sounds like this issue can now be closed, is that right?