David Spickett
David Spickett
I don't see why not. I see 22 instances of `find_executable` in llvm, a few are slightly different wrappers and one literally has a TODO to replace it with shutil.which....
https://reviews.llvm.org/D148522 https://reviews.llvm.org/D148527 https://reviews.llvm.org/D148528 https://reviews.llvm.org/D148529 After those the only `find_executable` are wrappers around `shutil.which` that add corner case handling.
All the above have landed, everything uses `shutil.which` now. As for `LooseVersion` I see `packaging.version.Version` mentioned as an alternative but as I said above, we'd have to make a copy...
Yeah I feared it might not be 100% the same. It might be best to write up a small set of tests that mimic what the existing users in llvm-project...
Surprisingly, yes :) https://github.com/llvm/llvm-project/commit/0c02329ff375100ddcf2cb104aebe97bb3c9126f As of now: ``` third_party/Python/module/pexpect-4.6/setup.py 2:from distutils.core import setup test/Shell/helper/build.py 444: from distutils.version import StrictVersion ```
PR to use packaging instead of pkg_resources: https://github.com/llvm/llvm-project/pull/93712
Thanks for the reminder, I just fixed one instance and checked again: ``` llvm-project$ grep -rnw . -e distutils ``` ``` ./compiler-rt/test/lit.common.cfg.py:716: from distutils.version import LooseVersion ``` This can be...
Started the process of removing the last compiler-rt use - https://discourse.llvm.org/t/psa-compiler-rt-linux-buildbots-will-in-future-require-the-python-packaging-module/88100
Trying to find out if the check_cfc script is in active use - https://discourse.llvm.org/t/is-anyone-using-the-check-cfc-script/88259.
The last remaining reference is: ``` llvm-project$ ack distutils clang/utils/check_cfc/setup.py 5:from distutils.core import setup ``` This is in a utility script, and only for supporting Windows. There are users of...