llvm-zorg icon indicating copy to clipboard operation
llvm-zorg copied to clipboard

docs-libc-html not updating

Open nickdesaulniers opened this issue 1 year ago • 6 comments

some time between llvm commits 0afee850de1ebe9af71bdf727d906fefa78ad68c (Jan 10) and c2771ca284124861de76ba1853ac4f26e09b8497 (Jan 14), https://libc.llvm.org/headers/index.html stopped updating. The ninja target would be docs-libc-html.

I think publish-sphinx-docs is the bot for this.

If we look at the cmake invocation, we have:

$ cmake -DLLVM_ENABLE_SPHINX=ON -DSPHINX_OUTPUT_HTML=ON -DSPHINX_OUTPUT_MAN=OFF -DSPHINX_WARNINGS_AS_ERRORS=OFF -DLLVM_ENABLE_ASSERTIONS=OFF -DCMAKE_BUILD_TYPE=Release '-DLLVM_ENABLE_PROJECTS=clang-tools-extra;polly;lldb;lld;openmp;llvm;clang;flang' '-DLLVM_LIT_ARGS=-v -vv' -GNinja ../llvm-project/llvm

and the ninja invocation:

$ ninja -j 24 docs-llvm-html docs-clang-html docs-clang-tools-html docs-lld-html docs-lldb-html docs-flang-html docs-openmp-html docs-polly-html

Both of which seem to be missing libc...

nickdesaulniers avatar Jan 17 '25 17:01 nickdesaulniers

Ah publish-runtimes-sphinx-docs is the bot for this, it's been red. Let's see why.

nickdesaulniers avatar Jan 17 '25 17:01 nickdesaulniers

Ah, it's me. I'm guilty your honor:

CMake Error at /usr/local/share/cmake-3.25/Modules/CheckLibraryExists.cmake:71 (try_compile):
  Only libraries may be used as try_compile or try_run IMPORTED
  LINK_LIBRARIES.  Got pthread of type UTILITY.
Call Stack (most recent call first):
  /home/buildbot/as-worker-4/publish-runtimes-sphinx-docs/llvm-project/libcxx/cmake/config-ix.cmake:130 (check_library_exists)
  /home/buildbot/as-worker-4/publish-runtimes-sphinx-docs/llvm-project/libcxx/CMakeLists.txt:479 (include)

https://github.com/llvm/llvm-project/commit/539b15b41a6a01017c0a555e89b7d2b62ba194d2

nickdesaulniers avatar Jan 17 '25 17:01 nickdesaulniers

I've tried to force a clean build from the web ui, but the build requests are queued up still. @gkistanova can you manually clean the cmake build dir for as-worker-4's publish-runtimes-sphinx-docs so that I can see if this is related to cmake cache?

I'm able to build locally fine, though the buildbot is using cmake 3.25 and I have cmake 3.29.6.

nickdesaulniers avatar Jan 17 '25 17:01 nickdesaulniers

A clean build does not seem to fix that. https://lab.llvm.org/buildbot/#/builders/178/builds/1272

gkistanova avatar Jan 18 '25 23:01 gkistanova

Ok, thanks for verifying. For now, I will just partially revert https://github.com/llvm/llvm-project/commit/539b15b41a6a01017c0a555e89b7d2b62ba194d2, and file a TODO to look into this further at some point in time in the future.

nickdesaulniers avatar Jan 21 '25 21:01 nickdesaulniers

publish-runtimes-sphinx-docs looks like it's back to green now!

nickdesaulniers avatar Jan 23 '25 20:01 nickdesaulniers

@nickdesaulniers sounds like this issue can now be closed, is that right?

DavidSpickett avatar Apr 07 '25 14:04 DavidSpickett