David Goodwin

Results 134 comments of David Goodwin

the code implies your user doesn't have permission to edit the alias; does it have permission to modify the domain in question?

https://github.com/postfixadmin/postfixadmin/blob/master/model/PFAHandler.php#L432

as a user, if i try to add a non-fully-qualified foward, i see ![image](https://user-images.githubusercontent.com/203929/145094201-76cb10c0-4341-4036-b6c9-84fda37390b7.png)

when I login as an admin for a specific domain (in my case, just 'example.com' - so NOT a superadmin) - I see the same - where I can't edit...

![image](https://user-images.githubusercontent.com/203929/145095743-be3f9f27-0d35-4af4-8faa-d4670bd67fc8.png)

So at least for me, if i'm not a super-admin and the alias target is one of the ones defined in `special_aliases' ( https://github.com/postfixadmin/postfixadmin/blob/master/config.inc.php#L268 ) then edit permission is removed.

the code that's turning off editability is here - https://github.com/postfixadmin/postfixadmin/blob/52ed517f35fc2bfde193fad94ddd07d2e5cd4c8d/model/AliasHandler.php#L346

If you're adding support for check_recipient_access wouldn't you also add check_sender_access ? Relevant links : * http://www.postfix.org/postconf.5.html#check_sender_access and * http://www.postfix.org/postconf.5.html#check_recipient_access * http://www.postfix.org/access.5.html I'm not sure if such a feature should...

Thanks for reporting this - I can see the issue you're referring to.

we do have $CONF['mailbox_postpassword_script'] .... (I don't use it, but I think that's being run after the database has been updated, which isn't what you're asking for?) https://github.com/postfixadmin/postfixadmin/blob/aa1b80d17391160705e9ac6cffd0db94d6ff3723/config.inc.php#L618 and https://github.com/postfixadmin/postfixadmin/issues/408...