David Goodwin
David Goodwin
Yes - I was thinking your changes would be better if they were moved out into some sort of hook - where the admin-type decides what rules they want. We...
> Thank you kindly for catching and correcting my typos ! Most of them are from running 'composer psalm' and 'composer format' on the code. I haven't done much yet.
Thanks for taking the time to write and submit a PR. I'll try and look at this in the next few days. (It's a shame Postfix can't log directly to...
> @DavidGoodwin should be default set to 'NO'? Probably?
> Do you think it is not the best approach? Should I close the pull request? I'm hoping other users will voice their opinions :-)
@bnchdan why close?
Ideally we'd drop XMLRPC and move to something REST-ish ... as at least that'd be more understood/easier to debug/less magical/remove a dependency on ZF1....
(xmlrpc is only an optional dependency really ...)
@bnchdan thanks for the link - you'd need to call something boring like htmlspecialchars(..) on anything you embed into the XML like how you are - e.g. if my password...
I wouldn't expect the domain omission to be the problem.