David Cain comments

Results 37 comments of


                                            David Cain

`MultiLineBlockMixin` causes stack overflow from recursive `_get_assign_nodes()`

Great! I'll whip up a PR then and reference this issue. Thanks for reviewing. It will probably take me until this weekend to find the time.

`MultiLineBlockMixin` causes stack overflow from recursive `_get_assign_nodes()`

Sorry, haven't forgotten about this issue just yet, but it clearly took me more time than just a week to find the time. =) I'll hopefully have a PR out...

`MultiLineBlockMixin` causes stack overflow from recursive `_get_assign_nodes()`

Hi, Bryce. Pretty much any version of `thrift` should do, though I'm reproducing again this morning with `0.13.0`. I'll also use 3.7.7 and the pylint + astroid versions you used....

`MultiLineBlockMixin` causes stack overflow from recursive `_get_assign_nodes()`

Argh, sorry for leaving this issue unresolved for so long. I won't make any future promises about when I might tackle a PR, but maybe one day soon. In the...

ValueError in _get_pwned() when /range returns hash that exists more than 999 times

**Update**: even though the linked URL now reports results without commas, I'm still seeing this in the wild on other URLs. --- Hm, I wonder if the HIBP API itself...

ValueError in _get_pwned() when /range returns hash that exists more than 999 times

> I think we should all assume it's still doing it and will in the future so should continue to strip out and formatting that may be there. Oh, I...

Switch to using 3-clause BSD licence

I would be happy to license my contributions under the BSD 3-clause license.

Stop 500's on a non-JSON /auth request

@mattupstate, any input on this one? It closes a pretty easy mechanism for invoking 500's.

Stop 500's on a non-JSON /auth request

@dequis it's similar, but actually catches errors not handled by #70. If you were to pass a string or array with a valid JSON mimetype, `request.get_json()` will return something truthy....

Suggestion: Add dates to "also on"

Sure, that sounds like a very sensible (and very easy) QoL improvement. There's a somewhat limited amount of room for such a parenthetical. Would a 3-day day of the week...