David Cain
David Cain
Also, I should have paid closer attention to the issue -- the title says customizing how many _seats_, but I was assuming it was a simple customization for how many...
I could absolutely see there being some simple support for cars with extra storage (e.g. trip could support "2 cars with roof boxes/racks, or 3 cars normally") -- but trying...
@Blox-Blox - were you curious about the effects of re-running so that *all* trips get 3 cars? Or just surfing+skiing+bouldering trips? > Perhaps ski trips specifically get a behind-the-scenes bump...
> Ya. I was curious what happens if you rerun a Winter School lottery with all trips getting three cars instead of two. i.e. Does that leave trips that are...
Hey, thanks for the suggestion! So, it's fairly easy in HTML to force a given link to be opened in a new tab -- you just set `target=_blank` on the...
@rbarrois - any thoughts about this proposed change?
@george-zubrienko - oh absolutely, one could definitely make a config flag if desired. However, `filterwarnings` can also be used _right now_ to silence warnings on `dataclasses-json==0.6.7` (perhaps that's helpful to...
tl;dr: I imagine you could solve this concern with a smaller warning message: ```diff warnings.warn( - f"Failed to decode {value} Union dataclasses." + "Failed to decode Union dataclasses. " -...
@s4ke you'd originally commented on my PR: > We just ran into the case where according to this PR buggy behaviour logged out huge chunks of actual data into stdout....
Thanks for the review and for triggering CI, @andreasprlic - I can take a look at the failing unit tests and try to sort it out soon.