David Salvisberg

Results 127 comments of David Salvisberg

I think it is valuable to distinguish between form data and object data, especially for things like `InputRequired` vs. `DataRequired` which are different requirements. That being said, I think the...

Hi, no worries. There's type comments that work with Python 2.7, that can easily be automatically converted to inline type annotations using something like pyupgrade later on. Here's an example...

@arthurdejong One other challenge with inline type hints will probably be that current type checkers and typeshed only support Python versions that aren't EOL, there's still some support for 3.8...

If you decide that hard-dropping support for anything below 3.6 or 3.9 is acceptable for the benefit of inline type hints, I'd be happy to work on a PR, so...

I don't think we should make that the default behavior for TC100, but I would be open to adding an additional setting for that. Just like we have a strictness...

I'd actually prefer a setting over a separate error code, since the error message would be the same for both error codes, you're just changing the condition for when you...

@antazoey This actually looks like an issue with `@singledispatchmethod` not with the SQLAlchemy integration, since singledispatch needs to be able to inspect the signature at runtime so it can do...

That being said SQLAlchemy's `@declared_attr` may be affected too, the SQLAlchemy plugin doesn't currently handle it and there are probably some `@declared_attr` that require runtime access to some parts of...

@zanieb Unfortunately that doesn't appear to have fixed the problem: ``` > ~/.cargo/bin/uv --version uv 0.1.28 (192b214dc 2024-04-03) > ~/.cargo/bin/uv pip install pip Resolved 1 package in 1ms warning: Failed...

I think one sensible and easy-to-implement solution for this particular case is to special-case `Annotated` and treat itself and everything past the first element in the subscript as runtime context,...