David Salvisberg

> Is passing an empty dict something that happens in real code? If it isn't, we could just adapt our tests. That's a fair point, it's not really useful to...

It might also be a nice QoL improvement to wrap the return value in `Markup`, that way it would be possible to pass it into a `Markup.format` without having to...

I don't fully understand your expected vs. actual behavior. They both look correct to me and it's what happens, your two conditions are reciprocal, so they can't both trigger an...

The only way I can think of this scenario happening is if a class that uses this mixin, either directly or through one of its parent classes, defines its own...

@miketheman I think I found your bug, you're clearing `username.validators`, which doesn't get rid of the `validate_name` method. A more robust way to do this might be to replace the...

Good question, that just was the lowest hanging fruit that turned up by searching for `username.validators` in the repository. I can't really see a way for this case to happen...

> It sounds like this deserves its own dedicated command — it doesn't really feel like it deserves to be tacked on as a `pip list` feature. I feel weird...

> So ... is there a way to make stubtest ignore this error? (And why does stubtest even care about it?) It looks like you will need to use a...

@sondrelg I have never used it myself, so I can't really provide any useful input beyond a surface review.

There is a particular style I use for typing imports I would like to enforce that has always stopped me from enabling isort and it's somewhat related to this request....