DashKash54
DashKash54
> createSiweMessageWithRecaps - Using createSiweMessage under the hood, but adding recap resources to the SIWE message. Doesn't all the Siwe messages require resource to be allowed from the user? @Ansonhkg
I'm approving this PR, although there are still comments unresolved. Might be worth responding & resolving it. For certain comments we may also defer addressing them later but we should...
> This PR merges several other PRs https://github.com/LIT-Protocol/js-sdk/pull/439 https://github.com/LIT-Protocol/js-sdk/pull/438 https://github.com/LIT-Protocol/js-sdk/pull/436, so we can run the tests as they rely on the new features introduced in those branches. Is it juts...
Responded to your comments & left a couple new comments. After these are addresses this is good to merge 😄 @Ansonhkg
> @DashKash54 Are these also on `Manzano` and `Habanero` if we publish this as a `5.0.1` patch will it work on all networks? Not yet as the v0.1 release hasn't...
> If we merge this into `master` then other networks will be able to use these additions? should we point this pr at `staging/v6` instead? So we only publish it...
> @Ansonhkg this looks awesome! Thinking to get ready for this merger we should make a `release/6.0.0` branch where we can start merging this work into and doing test runs....
@Ansonhkg Still a bunch of unresolved comments. Can you please respond and resolve those, thanks