js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

Published 20 hours ago • verified publisher icon LIT-Protocol

feat: Tests for new chains on Cayenne

Open DashKash54 opened this issue 1 year ago • 7 comments

Description

Tests for new chains supported on Cayenne.

Type of change

  • [X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual Tests

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my code
  • [X] My changes generate no new warnings
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] Any dependent changes have been merged and published in downstream modules
  1. https://github.com/LIT-Protocol/lit-assets/pull/1135
  2. https://github.com/LIT-Protocol/lit_node_admin_app/pull/46

DashKash54 avatar May 10 '24 00:05 DashKash54

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 10 '24 00:05 CLAassistant

@DashKash54 Are these also on Manzano and Habanero if we publish this as a 5.0.1 patch will it work on all networks?

joshLong145 avatar May 10 '24 19:05 joshLong145

@DashKash54 Are these also on Manzano and Habanero if we publish this as a 5.0.1 patch will it work on all networks?

Not yet as the v0.1 release hasn't done for these networks

DashKash54 avatar May 10 '24 21:05 DashKash54

@DashKash54 Are these also on Manzano and Habanero if we publish this as a 5.0.1 patch will it work on all networks?

Not yet as the v0.1 release hasn't done for these networks

If we merge this into master then other networks will be able to use these additions? should we point this pr at staging/v6 instead? So we only publish it under the @cayenne tag?

joshLong145 avatar May 13 '24 16:05 joshLong145

If we merge this into master then other networks will be able to use these additions? should we point this pr at staging/v6 instead? So we only publish it under the @cayenne tag?

We can merge this after Habanero is deployed as it will contain these chains: https://github.com/LIT-Protocol/lit-os/blob/b5d56af53174d381fdc4de60c7a7319d506bb30a/components/common/salt/state/lit/core/blockchain/config/rpc-config.yaml#L1 @joshLong145

DashKash54 avatar May 16 '24 21:05 DashKash54

@DashKash54 can you change the base branch to staging/v6

joshLong145 avatar May 23 '24 18:05 joshLong145

@DashKash54 Looks like ci is still running the old e2e tests, i think something is wrong with the branch. Would you be able to rebase it onto staging/v6 or just recreate the pr off of that branch?

joshLong145 avatar May 23 '24 21:05 joshLong145

Closing as branch has not been updated. @DashKash54 please re open with an rebased / fresh branch as the CI is not properly running when re targeting staging/v6

joshLong145 avatar Jun 03 '24 14:06 joshLong145