Lorenz Wrobel
Lorenz Wrobel
now macos was successful 👀 very very interesting...
I mean I'm OK with yeeting this completely and adding a `writeToTag` and `readFromTag`. One of my big questions is how we should approach deserialization? I think that may prove...
I believe it is important to have a factory at a global and at an instance level. So global with instance level overrides is the best option I think
> Could just have a global registry which can be replaced with a different one at the instance level (I dont think we need some kind of inheritance here necessarily)...
@mworzala how would we go about serializing entity metadata? `MetadataHolder` only works with magic values, should we use those, even though they're bound to cause issues deserializing an entity when...
I think we'd need to add a kyori `Key` or `String` for each Entry in MetadataDef, which is a repetitive pain but doable (Waiting for reply so I don't do...
heap dump created by following code: https://1drv.ms/u/c/3f55ce5bc77fefb1/EcoPJZ6E9I1MoL47UMeN_rUBKvNsnRIy2ThQMWA6Xa7qGw?e=FWQ3NE (sneak peak of 1.7G)  ``` @Test public void clearing() { var ent1 = new Entity(EntityType.ZOMBIE); EntityTracker tracker = EntityTracker.newTracker(); for (var x...
profiler session: https://1drv.ms/u/c/3f55ce5bc77fefb1/Ecp1Ozuxj4FNruD_Fd9Re9EBWi087venp8jY49MACpJhgg?e=acShEd
Tbh I don't quite understand why you need any of this information. The code snippets I sent are easily tested, the origin of the leak is here: https://github.com/Minestom/Minestom/blob/c06118b288e7605b4449780469fa59d0a41a0fed/src/main/java/net/minestom/server/instance/EntityTrackerImpl.java#L277 where a...
Isn't an instance just a collection of chunks and entities? If this instance shares everything, you could also just use the original instance, or am I missing something?