Lorenz Wrobel

@mworzala please don't rebase this, I'll do it myself. Thx ❤️

> As far as I can tell the buffers you are force closing now are getting garbage collected anyway. The provided stacktrace in the corresponding issue tells the same. The...

> This should be handled as [we wrap the drop of the buffer](https://github.com/CloudNetService/CloudNet/blob/nightly/driver/impl/src/main/java/eu/cloudnetservice/driver/impl/network/netty/buffer/NettyNioBufferReleasingAllocator.java#L77) in a [CleanerDrop](https://github.com/netty/netty/blob/main/buffer/src/main/java/io/netty5/buffer/internal/CleanerDrop.java) which then delegates to our [DirectBufferFreeDrop](https://github.com/CloudNetService/CloudNet/blob/nightly/driver/impl/src/main/java/eu/cloudnetservice/driver/impl/network/netty/buffer/NettyNioBufferReleasingAllocator.java#L136) which explicitly frees the off-heap memory that is...

Are you trying to tell me that explicitly clearing the buffer everywhere in the code except those 3 places is intended? https://github.com/CloudNetService/CloudNet/blob/31b4a9951a81560c11e079465b721a81177fb4f0/driver/impl/src/main/java/eu/cloudnetservice/driver/impl/network/netty/NettyNetworkHandler.java#L114 https://github.com/CloudNetService/CloudNet/blob/31b4a9951a81560c11e079465b721a81177fb4f0/driver/impl/src/main/java/eu/cloudnetservice/driver/impl/network/chunk/splitter/NetworkChannelsPacketSplitter.java#L54 https://github.com/CloudNetService/CloudNet/blob/31b4a9951a81560c11e079465b721a81177fb4f0/driver/impl/src/main/java/eu/cloudnetservice/driver/impl/network/rpc/listener/RPCPacketListener.java#L98 +implicit releases https://github.com/CloudNetService/CloudNet/blob/31b4a9951a81560c11e079465b721a81177fb4f0/driver/impl/src/main/java/eu/cloudnetservice/driver/impl/network/netty/buffer/NettyImmutableDataBuf.java#L335 ... If we...

Just because netty is smart enough to detect when leaks happen, doesn't mean the leaks are supposed to happen in the first place is what I am on about. Tbh....

Idk if this will ever get merged, I am running my instance with leak detection enabled and haven't seen a leak since I added this. Before, I saw leak warnings...

I finally figured this out. Sending medium sized templates over the network repeatedly with node memory 256mb can cause problems. Netty allocates buffers of 3-5mb in my case, which under...

I have lied, netty does not cache buffers. Instead, when handling files, the jvm caches buffers, probably for performance. But when handling large files, like zipping templates, and then the...

I can't really tell, I'm running an older version from january on my production server. It doesn't happen on my development server, but there isn't much traffic there so who...

I am also against this, because players can enter configuration phase during game and not only when joining. Some documentation on the event saying "use Player#kick" should suffice imo.