Lorenz Wrobel
Lorenz Wrobel
you have no idea how much I need this
I mean one aspect I have is to use `shape` instead of `collisionShape`. Otherwise pressure plates won't work with touch handlers. It is unclear though of the exact implications that...
Soul sand is another consideration. The question I think is how do we define "touch". Is it if we are touching the collision bounding box, or is it if we...
Is there something that has to be changed?
Or set a flag that denies all logins before the logic happens, which in turn also removes the flag. Would work on all platforms, no issues EDIT: LuckPerms does something...
I feel like this should be configurable instead of fixed 60s (or 5s) Best would be a setting for the task imo. Some lobby template servers only need 5s and...
> Yes, the configuration should be available per-service, but that's not a simple task to do as the task configuration is not available to the service, unless we provide the...
> `InventoryCloseEvent` already supports getting and setting a new inventory, so personally I think `InventorySwapEvent` can be removed and all usages here can be replaced with `InventoryCloseEvent`, since this would...
Could also add a test to ensure the InventoryCloseEvent is not called twice. Considering with this PR that would be intended behaviour and is (I think) not tested anywhere
awkward but agreed it's a little unintuitive to get the old inventory via ``` InventoryOpenEvent event = ... event.getPlayer().getOpenInventory() ``` Thoughts about adding a method to the InventoryOpenEvent something like...