Yifeng Xiao

Results 15 comments of Yifeng Xiao

Admiral was crashed of OOM: ``` Jan 08 09:35:55 vic-st-h2-132.eng.vmware.com start_admiral.sh[1810]: java.lang.OutOfMemoryError: GC overhead limit exceeded Jan 08 09:35:55 vic-st-h2-132.eng.vmware.com start_admiral.sh[1810]: Dumping heap to /var/admiral/java_pid5.hprof ... Jan 08 09:35:59 vic-st-h2-132.eng.vmware.com...

Is there memory leaking or admiral starts with not enough memory? "-Xmx768M -Xms768M -Xss256K -Xmn256M" ``` Jan 07 06:11:10 vic-st-h2-132.eng.vmware.com start_admiral.sh[1810]: + '[' false = true ']' Jan 07 06:11:10...

The return value is 0 when JVM crashes, so admiral is not restarted by systemd. ``` systemctl status admiral.service ● admiral.service - Admiral is a highly scalable and very lightweight...

https://storage.googleapis.com/vic-product-ova-builds/vic-dev-v1.5.0-rc4-6889-009b4399.ova includes fix for this issue.

There are still failed checks, could you explain the reason if you want to merge it with failed checks?

We can pass through annotation "virtualmachineservice.vmoperator.vmware.com/service.endpointHealthCheckEnabled" from VMService to Service so this pr is not required. `externalTrafficPolicy` is not only an annotation and we also need to set the field...