tanzu-framework icon indicating copy to clipboard operation
tanzu-framework copied to clipboard

Restarts containers in post kubeadm for capz

Open geetikabatra opened this issue 2 years ago • 5 comments

Restarts containers in post kubeadm so that /etc/host values are loaded.This is a hack for lack of Azure NLB hairpin support as it does not work for all hostNetwork pods

Signed-off-by: Geetika Batra [email protected]

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

geetikabatra avatar Jan 09 '23 17:01 geetikabatra

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4259/20230109172928/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Jan 09 '23 17:01 github-actions[bot]

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4259/20230111151524/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Jan 11 '23 15:01 github-actions[bot]

There are still failed checks, could you explain the reason if you want to merge it with failed checks?

DanielXiao avatar Jan 12 '23 02:01 DanielXiao

@DanielXiao , let's do our testing on #4273 that combines the Azure bugs together. I'll be going to sleep soon, but @yastij and @sonasingh46 can pick up in a few hours.

randomvariable avatar Jan 12 '23 02:01 randomvariable

Codecov Report

Merging #4259 (b518681) into main (f39341f) will decrease coverage by 0.89%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4259      +/-   ##
==========================================
- Coverage   49.40%   48.50%   -0.90%     
==========================================
  Files         451      481      +30     
  Lines       44755    46875    +2120     
==========================================
+ Hits        22111    22738     +627     
- Misses      20560    22002    +1442     
- Partials     2084     2135      +51     
Impacted Files Coverage Δ
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) :arrow_down:
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
...li/plugin/isolated-cluster/imgpkginterface/util.go 50.00% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/list.go 11.36% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 8.73% <0.00%> (ø)
cmd/cli/plugin/cluster/kubeconfig_get.go 8.82% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jan 12 '23 02:01 codecov[bot]