Daniel Lo Nigro
Daniel Lo Nigro
> Out of all the files change it will find the max change and report that + it's file name This sounds like a great idea!
Oh, interesting. I think it's because I added logic to not comment if there's no regression, but it doesn't handle the case where a comment already exists and needs to...
Thanks for the bug report, I'll try to look into this soon :)
> I just added BuildSize to a repo, and pushed some artifacts on CircleCI on this PR: https://github.com/etalab/geo.data.gouv.fr/pull/553 but I’m not getting a comment. For this particular one, the base...
> t. Their comment is posted after the PR is created (if they already have build data), or when the first build finishes (the PR already exists); then updated whenever...
I opened a new issue to track that particular issue (submitting PR after the build has completed): https://github.com/Daniel15/BuildSize/issues/27
> My repo is private, can BuildSize only work with public repos? Yeah, that's the case at the moment. Sorry it's not fully documented - I built most of BuildSize...
Yeah there's a todo for that in the code: https://github.com/Daniel15/BuildSize/blob/0e39cd8040350631b35a6e85129a2376a9ecdac2/app/Services/Build/AbstractBuildService.php#L73. I haven't seen many projects that change the default branch, but I agree that it would be good to have!
Should be doable. I'm not very familiar with Gitlab, but it looks like it supports saving build artifacts: https://docs.gitlab.com/ee/user/project/pipelines/job_artifacts.html
I'll try to take a look at it if I get a chance. Haven't gotten a chance to look through the code yet. --- Regards, Daniel Sent from my phone...