Dani Guardiola
Dani Guardiola
I created a PR that targets this one (so that it can be merged after this one) that clarifies what I intend to add: https://github.com/WordPress/gutenberg/pull/64943 (`useEvent` and `useObserveElementSize`). Then, a...
Inner styles should not be overriden for `@wordpress/components`, in general. If we want a version of tabs that stretches to fill its container, that should be requested and implemented (if...
@scruffian I think that's reasonable. Please note that the first example in the description has an intentional design detail where the tabs indicator overlaps the border below it, as can...
Just wanna say two things: - Great work, thank you for doing this! - This is a great opportunity to make sure this component is rock-solid in terms of a11y....
@jeryj love that! This PR is also a great chance to add that as a follow-up, and get it going in all sidebars.
I agree with @youknowriad, let's leave the visual design discussion separate from this PR. Let's still make sure this component is accessible to all users, please :)
This PR is almost good to go. Just need to update and solve conflicts from upstream, and then get TypeScript happy. I've spent hours trying to make TypeScript happy, and...
@diegohaz happy to say, this is ready to go now with your approach in #4364 applied here :) I tweaked it a little but it's effectively the same idea. Check...
Also thanks to @paularmstrong for taking a stab at the TypeScript setup!
> it might be a good idea to test the packages published by CodeSandbox Done! See my playground here: https://stackblitz.com/~/github.com/DaniGuardiola/ariakit-solid-playground?file=src/App.tsx If there's nothing else, this is ready for merge and...