Dani Guardiola

Results 263 comments of Dani Guardiola

@mtias after doing a deeper dive into this, I think I agree with you re: close buttons. However, there are some critical a11y concerns we need to address. - Ensuring...

Let me see if I understood correctly: the purpose of having these be contiguous in the DOM is so that the sidebar tab stops are placed right between the disclosure...

> Anyways, I'd still strongly suggest to make all panels have a header with a visible title (a heading with an appropriate level). Any section of the UI should be...

@diegohaz I want to contribute a fix to this, if that's what makes sense to do. One observation here: There are some tricky interaction conflicts. For example, pressing arrow down...

@oandregal I have added an updated repro to the description, as yours wasn't entirely correct (the element that the composite item needs to be "merged" with is `MenuButton`, not `MenuProvider`)....

Digging deeper into this, it seems like this is a symptom of the composite item that's merged with the menu button not being registered in the composite collection store. Still...

Isn't this somewhat similar to what @jjenzz has discussed multiple times in the context of Radix UI primitives regarding context scoping? @diegohaz

The workaround of passing the store explicitly does indeed work: https://stackblitz.com/edit/vitejs-vite-kw6x9j?file=src%2FApp.tsx One important detail is that the "topmost" component should be the CompositeItem (e.g. `

@diegohaz any quick way to create a starter codesandbox using this PR's version?

Thanks @diegohaz, here's the example: https://stackblitz.com/edit/vitejs-vite-ihjzqp?file=src%2FApp.tsx This should work with this PR's version.