Aaron Layfield
Aaron Layfield
@Benoitsob I think this is the happy middleground to suit all user cases (I had nothing wrong with the original, but I think this is more thorough and won't hurt...
@mxsavchenko I'm closing this because this seems more dangerous than good to me. What's the justification? These persistent directories are intentional.
@trawler Fixed. I'm slowly going to get up to speed with everything and update what needs to be. I've neglected the repo for far too long - Sorry.
Ignore me... I thought this was a K8s job, not the github workflow. Merging :)
Yes. #238 would do this, it was neglected. I'll re-review to see if this is definitely fit for purpose and try to get this merged in.
@alexku7 Can you throw me the commit where this was changed? I'm not entirely sure why this would have been removed in the first place.
I've neglected this a little bit because I'm currently getting ready to move back to my home country. Let me try and sneak some fixes in and some requests next...
@mhkarimi1383 https://github.com/dandydeveloper/charts/blob/f39ee0e89964e90e781c682d5333f65b75083eaf/.ci/ct-config.yaml#L3 Apparently we just use base values right now, but we could include a specific ci.yaml that can handle all the test cases. I thought we already had this!...
LGTM, sorry for this taking so long. Merging when it passes.
@imvalient Looks like the CI sees some problems. Possibly indentation? Can you triple check your work here?