charts icon indicating copy to clipboard operation
charts copied to clipboard
verified publisher icon DandyDeveloper

[stable/redis-ha] ✨ feat: multiple values for redis configs

Open mhkarimi1383 opened this issue 2 years ago • 3 comments

What this PR does / why we need it:

When we need to have multiple values for some configs (e.g. loadmodule), yaml is not okay with multiple values for the same key.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Variables are documented in the README.md
  • [x] Title of the PR starts with chart name (e.g. [stable/mychartname])

mhkarimi1383 avatar Jan 30 '23 11:01 mhkarimi1383

I didn't find that CI.yaml file I should add a new values file into the ci directory in the chart?

mhkarimi1383 avatar Mar 02 '23 05:03 mhkarimi1383

@mhkarimi1383

https://github.com/dandydeveloper/charts/blob/f39ee0e89964e90e781c682d5333f65b75083eaf/.ci/ct-config.yaml#L3

Apparently we just use base values right now, but we could include a specific ci.yaml that can handle all the test cases. I thought we already had this! I was wrong.

But under the ci/ folder in the chart, I'd recommend adding something here and then updating the file I've linked. If you have any Qs or think it's not worth the effort, let me know!

DandyDeveloper avatar Mar 08 '23 00:03 DandyDeveloper

@DandyDeveloper I added a values file for testing, etc.

As my reading that should work without any changes in https://github.com/dandydeveloper/charts/blob/f39ee0e89964e90e781c682d5333f65b75083eaf/.ci/ct-config.yaml

mhkarimi1383 avatar Mar 08 '23 21:03 mhkarimi1383