charts icon indicating copy to clipboard operation
charts copied to clipboard
verified publisher icon DandyDeveloper

[charts/redis-ha] Add extraAnnotations value allowing to add annotations for every sing…

Open imvalient opened this issue 3 years ago • 6 comments

…le resource generate, from a single value declaration

What this PR does / why we need it:

I've been using this chart for a long time. Right now, I'm trying to add a custom annotation to all the resources generated by this chart, but currently, it's not supported. This PR enables this feature.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Variables are documented in the README.md
  • [x] Title of the PR starts with chart name (e.g. [stable/mychartname])

imvalient avatar Oct 03 '22 17:10 imvalient

LGTM, sorry for this taking so long. Merging when it passes.

DandyDeveloper avatar Mar 02 '23 01:03 DandyDeveloper

@imvalient Looks like the CI sees some problems. Possibly indentation? Can you triple check your work here?

DandyDeveloper avatar Mar 02 '23 01:03 DandyDeveloper

@DandyDeveloper thanks, it should be fixed now.

imvalient avatar Mar 02 '23 12:03 imvalient

@DandyDeveloper, I think that you have to approve the needed GitHub actions, right?

imvalient avatar Mar 07 '23 08:03 imvalient

@imvalient I actually think GH ACtions was having problems the other day... Going to do what I can to get these running.

DandyDeveloper avatar Mar 08 '23 00:03 DandyDeveloper

@imvalient Looks like its still broken. FYI: Do some local helm template . or helm install with and without the annotations. It should show the same as what we're seeing in the CI.

DandyDeveloper avatar Mar 08 '23 00:03 DandyDeveloper