Danack comments

Results 291 comments of


                                            Danack

Fixed compatibility with PHP 8.2+

I think this is not needed after merging #616 ? I will add PHP 8.2 to the test runner.

Imagick::getRegistry() may return false

Thanks. Merged in 0d9216c478a2e0043d446fa3ea68c0d79795414f

Clean memory in ImagickKernel::fromMatrix

Thanks. Merged in f22dd99176c2e0760ade98abd504085a104d4905 and 9076cc80446be82d8503ad635cac3c286edb4a64

Clean memory in ImagickKernel::fromMatrix

Actually, running the tests with the memory checker ` php run-tests.php -m tests/145_imagickkernel_coverage.phpt` gives errors about this. So I've effectively reverted the changes until I can dig into what is...

Release memory in Imagick::getImageArtifacts()

> Is there anything left before the PR becomes closed? I don't think so. Sorry for not closing it for ages.

Remove "const" as the value is actually changes

Thanks. Yeah, probably better safe than sorry. Merged in c1ec339acdcc3ce00fe507b306384d6de1733c01

Use classes in function prototypes as it's used in the code

Thanks. Merged in 47ee6747713c615408a9c134f4627da2f2712481 > I couldn't find how I could cause this... It's not you. It's caused by new constants being added to ImageMagick, and there is a simple...

Release memory in Imagick::getConfigureOptions()

Hi, I appear to have already committed these in 2b0ecc4e1b429236c19a428de49403b27b7c3576 and d521b3ce9dfc98d1e304a073a67b1fd7fd760235 but forgot to say anything here. If you're able to, please can you give me (or point me...

Achievement for ensuring project is still maintained

Those comments can arise either because a repo is dead and abandoned with bugs, or it is just 'done' and doesn't need any maintenance. There's probably a good name related...

CPU pegged at 100% and sched_yield() called in infinite loop when OpenMP enabled

This looks very much like it was an issue in OpenMP that should be fixed now. I'm going to close this issue as I doubt there is anything for me...