imagick icon indicating copy to clipboard operation
imagick copied to clipboard

Use classes in function prototypes as it's used in the code

Open mikhainin opened this issue 1 year ago • 1 comments

Hi there,

There is another couple of methods that return the class Imagick but the signature claims bool. This causes some tests to fail for debug build of PHP.

Please, let me know if there is anything else to be improved

mikhainin avatar Mar 16 '23 10:03 mikhainin

It looks like there's something with the build actions. I couldn't find how I could cause this...

value 'BC5Compression' is missing for enum CompressionType.

mikhainin avatar Mar 16 '23 10:03 mikhainin

Thanks. Merged in 47ee6747713c615408a9c134f4627da2f2712481

I couldn't find how I could cause this...

It's not you. It's caused by new constants being added to ImageMagick, and there is a simple check in a github action to check all constants that need to be are listed in Imagick. That should probably only be done on the master branch.

Danack avatar Jun 30 '24 20:06 Danack