Danny Tuppeny

Results 1798 comments of Danny Tuppeny

@bwilkerson using a single-character class name slightly masks the issue here. If you make the class name much longer, when your cursor is in `new` you get this (which initially...

You're right, it's probably better to just fix entirely. Although whatever we do, we'd need to decide whether to have the highlighting issue or drop the `new` references for any...

> I think we want to switch to the `Occurrences` from the server eventually. If you did, would it support different lengths? (eg. having `new` in `Foo.new` and `Foo` in...

I started implementing this by adding additional data for lengths, but discovered that for the original protocol things are a little different to LSP and it's not clear to me...

I had another quick look at this today and it seems the original bug is no longer there, because `new` is always highlighted as if it's different to the constructor...

Thanks - I think I have it working as described above now, working on a CL at https://dart-review.googlesource.com/c/sdk/+/406822. https://github.com/user-attachments/assets/ca01d733-347a-4796-8ddc-28136388c3bb For the legacy protocol we can't support occurrences with multiple lengths...

> If IntelliJ isn't using the legacy protocol, then we should remove support for the protocol in order to reduce maintenance costs. Makes sense. I've opened https://github.com/dart-lang/sdk/issues/60043 to track this...

Is this consistently failing or was it just once? Is it only on ARM? (I can't repro with my x86 Windows PC).

While investigating https://github.com/dart-lang/sdk/issues/55705 I'm seeing this issue locally quite reliably. Re-opening this to move the discussion here. The error is caused by the test teardown trying to send a terminate()...

So, I can reproduce the issue seen here in an isolated script.. It runs "dart --version" and tries to write to the stdin stream even though the process will is...