Danny Tuppeny

Results 1798 comments of Danny Tuppeny

Can you provide some motivation for this? Those things are types so it seems like they should be coloured as such. Unfortunately we can't change colours conditionally in a textmate...

One option is that we change `support.class.dart` to `support.class.primitive.dart` here (and add `String` to the list): https://github.com/Dart-Code/Dart-Code/blob/622472f313ac69e98102e6d243ce9969c3ad64e3/syntaxes/dart.json#L231-L234 This should keep the same colouring by default, but I think would allow...

> I use semantic tokens. Ah sorry, I misunderstood from comments in https://github.com/Dart-Code/Dart-Code/issues/4963 and thought you had semantic tokens disabled. Semantic Tokens will completely replace the textmate grammar (this is...

> These should have a semantic token type of constant. It's not clear to me that it makes sense to have a _type_ of constant, because there many different things...

As far as I know, we can't add arbitrary buttons into the editor like this - there are no VS Code/LSP APIs for it. I think the best we could...

> it seems that a lot of things depend on https://github.com/dart-lang/tools/issues/1287 Anything that requires an understanding of the markdown, yep. To know where things like code blocks are, the markdown...

I'm tidying up the issue tracker and closing this since it's not something actionable here and there doesn't appear to be much demand. We can re-open if things change (such...

Small repro: ```dart final a = AAAAAAAAAAAAAAAAAAAAAAA.new; class AAAAAAAAAAAAAAAAAAAAAAA { AAAAAAAAAAAAAAAAAAAAAAA(); } ``` Likely related to `new` but using the length of the class name instead of the length of...

@bwilkerson the current implementation of Occurrences assumes that all occurrences have the same length: ```dart class Occurrences { List offsets; int length; } ``` This doesn't handle constructors referenced using...