Danny Tuppeny

Results 1798 comments of Danny Tuppeny

Fixed by https://github.com/dart-lang/sdk/commit/8d5794aa70e6a96187f2eff9c8ade579fb5e1b84. The change ships in a future SDK release.

We can't put links in the main text here (VS Code would have to do that), but starting recently, we do detect it and put a clickable link on the...

Sorry for the delay, I somehow missed this. This seems similar to https://github.com/dart-lang/sdk/issues/49081. The file that contains the definition is being added but we should search for a public import....

@bwilkerson slightly related a discussion we had last week.. Today, fixes like "create missing override" are computed up-front and included inline in the `textDocument/codeActions` response. Fixing the issue above will...

https://dart-review.googlesource.com/c/sdk/+/365804 should fix the drive letter mismatch (oddly that test hasn't changed in 2yrs.. not sure if the drive letter casing is somehow different on some bots for temp directory?)....

I guess many of those failures could be the drive letter issue. Let's land the fix above and then review the stats.. if there are still failures and that wasn't...

A fix for the second issue (drive casing) has landed. I believe the first issue is the same as https://github.com/dart-lang/sdk/issues/55313 - let me know if we should close this as...

@derekxu16 are you able to review what this dashboard looks like now with some of the fixes above landed?

Thanks - if I'm looking at the right failure, the recent failure is "The pipe is being closed" which I think is the same issue discussed in https://github.com/dart-lang/sdk/issues/55313 (this needs...

I think the original issue here may be resolved by the fix for https://github.com/dart-lang/sdk/issues/55313, however looking at https://dart-ci.firebaseapp.com/#showLatestFailures=false&test=pkg/dds/test/dap/integration/debug_exceptions_test, there are some different recent failures: https://dart-ci.appspot.com/log/pkg-linux-release/unittest-asserts-release-linux-x64/28665/pkg/dds/test/dap/integration/debug_exceptions_test ``` 00:10 +6 -1: debug...