DanRyanIrish

Results 94 comments of DanRyanIrish
trafficstars

So how would like work? Output a new axes object representing the FOV?

Hi @adolliou. This issue was mentioned in the ndcube matrix chat last week but I was on vacation. @MJWeberg is right in answering your first question. `NDCube.rebin` does not propagate...

Has this PR been superseded by #64? Or does it do other integral work also needed?

After the discussion at the STIX meeting last week, here's an update on one option for the refactor # Overall structure for fitting a single model to a spectrum/multiple spectra...

The above is my suggested approach based on my current thinking. Open to changes as we discover more about implementing this in practice.

After our productive discussion yesterday, I thought it would be helpful to clarify what I took from others' contributions, and how my thoughts have evolved on reflection. The main concerns...

I agree. There is probably a minimal API required by a representation of a response, e.g. the input and output spectral grid. But such a response object must be able...

> I guess the main point is that our `Response` object is more like a Spectrum object in terms of interface and function than a model. Also a large fraction...

I should point out a likely future direction of `NDCube` is to add an attribute contained an `NDCoords` class, which provides in easier API for accessing coordinate info. A possible...

Hi @elastufka. This looks good to me. The only test I see failing is the codestyle. You should be able to run `tox -e codestyle` from your terminal in the...