sunkit-spex icon indicating copy to clipboard operation
sunkit-spex copied to clipboard

Xspec functions

Open elastufka opened this issue 2 years ago • 4 comments

PR Description

Add XSPEC-compatible models, since I can't fix them in the big PR anymore...

PR Checklist

  • [X] I have followed the guidelines in the Contributing document
  • [X] Changes follow the coding style of this project
  • [ ] Changes have been formatted and linted
  • [ ] Changes pass pytest style unit tests (and pytest passes).
  • [ ] Changes include any required corresponding changes to the documentation
  • [ ] Changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • [X] Changes have a descriptive commit message with a short title
  • [X] I have added a Fixes #XXXX - or Closes #XXXX - comment to auto-close the issue that your PR addresses

elastufka avatar Apr 06 '22 12:04 elastufka

Codecov Report

Base: 32.47% // Head: 32.21% // Decreases project coverage by -0.25% :warning:

Coverage data is based on head (e45335b) compared to base (4bc8937). Patch coverage: 24.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   32.47%   32.21%   -0.26%     
==========================================
  Files          18       19       +1     
  Lines        3098     3203     +105     
==========================================
+ Hits         1006     1032      +26     
- Misses       2092     2171      +79     
Impacted Files Coverage Δ
sunxspex/emission.py 92.20% <ø> (ø)
sunxspex/xspec_models.py 24.76% <24.76%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar May 12 '22 08:05 codecov-commenter

what else needs to be done in order for this to be merged? @ whover is responsible

elastufka avatar Jul 18 '22 11:07 elastufka

Hi @elastufka. This looks good to me. The only test I see failing is the codestyle. You should be able to run tox -e codestyle from your terminal in the root directly of your local sunxspex clone. You might need to do conda install tox first if you don't already have it installed.

Also, you should pull the latest version of the main branch.

Finally, should the thermal function be named something a bit more helpful? Like thermal_emission?

DanRyanIrish avatar Aug 30 '22 15:08 DanRyanIrish

ok, should be done - I don't know why it's still failing coedstyle since I ran autopep.

elastufka avatar Sep 09 '22 14:09 elastufka

Closing for the moment revisit after refactor

samaloney avatar Jun 16 '24 21:06 samaloney