Integrals

[elastufka]

PR Description

Code that performs thick/thin target integration is shorter, more legible, slightly more Pythonic, and gives the same results as the IDL code (see tests)

Unfortunately, it isn't any faster but hopefully it is an easier starting point for improvement than the IDL translation

PR Checklist

• [X] I have followed the guidelines in the Contributing document
• [X] Changes follow the coding style of this project
• [X] Changes have been formatted and linted
• [ ] Changes pass pytest style unit tests (and pytest passes).
• [] Changes include any required corresponding changes to the documentation
• [ ] Changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
• [X] Changes have a descriptive commit message with a short title
• [ ] I have added a Fixes #XXXX - or Closes #XXXX - comment to auto-close the issue that your PR addresses

Addresses #51 but does not fix or close it

[codecov-commenter]

Codecov Report

Merging #58 (7be61be) into master (c357470) will decrease coverage by 67.48%. The diff coverage is 0.58%.

@@             Coverage Diff             @@
##           master      #58       +/-   ##
===========================================
- Coverage   93.48%   25.99%   -67.49%     
===========================================
  Files           5        5               
  Lines         629      731      +102     
===========================================
- Hits          588      190      -398     
- Misses         41      541      +500     

Impacted Files	Coverage Δ
sunxspex/__init__.py	100.00% <ø> (ø)
sunxspex/emission.py	0.29% <0.58%> (-92.87%)	:arrow_down:
sunxspex/thermal.py	27.66% <0.00%> (-68.38%)	:arrow_down:
sunxspex/constants.py	50.00% <0.00%> (-38.89%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c357470...7be61be. Read the comment docs.

[DanRyanIrish]

Has this PR been superseded by #64? Or does it do other integral work also needed?

[samaloney]

No it still good probably needs to be rebased to use #64 and add a new integrator to use the the multiprocessing. Also not sure about adding a lot of these dependancies even if only as optional.

[samaloney]

Closing for the moment - revisit when refactoring the integration codes