Dan Albert

Results 430 comments of Dan Albert

Presumably you're getting your system's make and not the NDK's when you make that change. If you're using an older make there are going to be some broken parts of...

Enumerated what I think are all the subtasks here and filed bugs for them (task list in the OP). LLVM is ~done (we just need to take the latest version),...

You're welcome to use those. We need to update the ones that we build ourselves.

Good catch. Filed a bug for that.

I think https://github.com/android/ndk/issues/1410 is the thread you want. The fix is in the next release, and https://android-review.googlesource.com/c/platform/ndk/+/1855814 was the fix (in the other thread, but buried in the middle).

Is the problem maybe that the trace only goes to stderr and not logcat?

What device? Probably more interesting, what OS version? I could have sworn we switched the common sanitizer logging over to syslog ages ago (L or M). syslog as of about...

I didn't realize that logwrapper was used by default with wrap.sh, but the code agrees with you. I can't speak to why this doesn't work on LineageOS, but given that...

I'll leave it open so we remember to fix the docs

I'm not sure there's much value in keeping `asan_device_setup` in a world where we have wrap.sh.