Jie Fu (傅杰) comments

Results 6 comments of


                                            Jie Fu (傅杰)

8291600: [vectorapi] vector cast op check is not always needed for vector mask cast

The performance improvement is impressive on x86 with avx2. Can you clarify what tests did you do? Thanks.

8291600: [vectorapi] vector cast op check is not always needed for vector mask cast

Thanks for the update. May I ask can we do it like this? ``` diff --git a/src/hotspot/share/opto/vectorIntrinsics.cpp b/src/hotspot/share/opto/vectorIntrinsics.cpp index 66bacf0..c4e807a 100644 --- a/src/hotspot/share/opto/vectorIntrinsics.cpp +++ b/src/hotspot/share/opto/vectorIntrinsics.cpp @@ -2494,8 +2494,9 @@ bool...

8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

> So you're trying to make sure we have a minimum COMPILATION_TIMEOUT value of 5 seconds, but I'm not sure why you want that. With the current patch, `COMPILATION_TIMEOUT` may...

8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

> Definitely not. Traditional default value for no specified timeoutFactor value is 1.0. Okay, you're right. This is because the timeoutFactor may be used by other tests too.

8295268: Optimized builds are broken due to incorrect assert_is_rfp shortcuts

> > LGTM > > Thank you! Trivial, or? Yes, I think it's trivial. Thanks.

[Bug]: vllm_C is missing.

I came across the same kind of bugs today. Finally, I got the failing reason and fixed it just by dumping the error msg: https://github.com/vllm-project/vllm/pull/5282 .