8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

[dcubed-ojdk]

A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG setting when waiting for a compilation to finish.

This fix is being tested in my jdk-20+10 stress testing run.

The usual Mach5 timeoutFactor is 4.0 with slower configurations using a timeoutFactor of 10.0. In my stress testing, I use release-bits: 4.0, fastdebug-bits: 6.0 and slowdebug-bits: 12.0.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9844/head:pull/9844
$ git checkout pull/9844

Update a local copy of the PR:
$ git checkout pull/9844
$ git pull https://git.openjdk.org/jdk pull/9844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9844

View PR using the GUI difftool:
$ git pr show -t 9844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9844.diff

[bridgekeeper[bot]]

:wave: Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@dcubed-ojdk The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dcubed-ojdk]

/label add hotspot-runtime

[openjdk[bot]]

@dcubed-ojdk The hotspot-runtime label was successfully added.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (cd61c316)
• 00: Full (bd9be934)

[openjdk[bot]]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

Reviewed-by: lmesnik, alanb, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• 07c9ba74fa3baebffcc15d3ee6ef941edf6be1a3: 8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr
• 235151ead89f9102e3a57ba8f88807f180887866: 8292676: Remove two kerberos tests from problem list
• df5209e70fd92ec6bda4e7356a3ad121732f6c66: 8292683: Remove BadKeyUsageTest.java from Problem List
• 74d3330e106f2f920bf264356e4f25f8f6c11580: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
• 57aac2ab6569c18a56e9a36f174bb0bf09955f83: 8290981: Enable CDS for zero builds
• 6a8a531359295849113aa14fd6cba21c886decf3: 8292564: x86: Remove redundant casts in Assembler usages
• 7244dd6fab0c516ed76af594593b8378512620c8: 8292267: Clean up synchronizer.hpp
• 1f3578b79c6355b976d64756da7e4a8af32c2987: 8292446: Make TableRateStatistics optional in CHT
• 45dec480ef6f1d5509f4afbbf414c69584ac252e: 8292592: JFR test TestNative is not reliable due to low rate of sampling.
• 58aae340a9892889ef8784ef9360bb7e0af85ddd: 8292576: Improve wording of AccessFlag-related specs
• ... and 82 more: https://git.openjdk.org/jdk/compare/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

@lmesnik, @DamonFool and @AlanBateman - Thanks for the reviews.

[DamonFool]

So you're trying to make sure we have a minimum COMPILATION_TIMEOUT value of 5 seconds, but I'm not sure why you want that.

With the current patch, COMPILATION_TIMEOUT may become less than 5_000, which may lead to more failures on various platforms. That's why I suggest let COMPILATION_TIMEOUT >= 5_000, which won't make things worse.

Thanks.

[DamonFool]

Definitely not. Traditional default value for no specified timeoutFactor value is 1.0.

Okay, you're right. This is because the timeoutFactor may be used by other tests too.

[dcubed-ojdk]

Sorry for the delay in getting back to this PR. I've been focused on GateKeeping issues instead.

This latest update:

• Scale the original COMPILATION_TIMEOUT value of 5 seconds by timeoutFactor.

makes the test happy on my linux-x64 stress runs. My macosx-aarch64 stress runs are still not happy, but I'm still gathering data on those runs. I haven't found a COMPILATION_TIMEOUT initial value that works every time yet. The values I've tried so far:

• 1_000 - the original value in the PR
• 5_000 - the original value in the test before I changed it
• 10_000 - simple doubling
• 20_000 - simple doubling again, testing this value now and thru the weekend

I'm inclined to move ahead with the 5_000 value scaled by timeoutFactor. I think I need to spend some time to determine why macosx-aarch64 is so much slower than linux-x64 for this test.

[dcubed-ojdk]

@DamonFool - Thanks for the re-review!

[dcubed-ojdk]

/integrate

[openjdk[bot]]

Going to push as commit 54843b700a463e75cd23a23df8ec5dc73b80f105. Since your change was applied there have been 117 commits pushed to the master branch:

• 8a0c3e53d541395ac32d656ac64d20ca0b9a187c: 8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java
• 8e8ee4b6f22657a7efba8d7998f3c309f334a086: 8292596: Make SymbolHashMap a ResourceHashtable
• aa9b8f04bf74d5fa00f2b27895e7369abea3a930: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16
• f95ee7960328410551a6948053d1ff0ec3d8c53d: 8292566: Add reference to the java.nio.file package in java.nio package documentation
• 45c3e898ed538545921395372fe507e9111401e1: 8292316: Tests should not rely on specific JAR file names (jpackage)
• db772276848f6ad2d4d13e892bcd0eb3123d030f: 8282684: Obsolete UseContainerCpuShares and PreferContainerQuotaForCPUCount flags
• 256b52387b7267c234f03aac19422e59a77d956f: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
• e561933907bbab0a42f1796fa12f582b3a347312: 8292623: Reduce runtime of java.io microbenchmarks
• dcd78020e4cd064061ac892c566c94fb744859c4: 8292708: Rename G1ParScanThreadState::flush to flush_stats
• 16593cf51c3d994ba4a6d28ab97e519dfd53f37b: 8292717: Clean up checking of testing requirements in configure
• ... and 107 more: https://git.openjdk.org/jdk/compare/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@dcubed-ojdk Pushed as commit 54843b700a463e75cd23a23df8ec5dc73b80f105.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dcubed-ojdk]

jdk/internal/vm/Continuation/Fuzz.java* passed 12 times (2 sub-tests x 6 configs) in two different Mach5 Tier1 job sets.