Daniel McNab

Results 255 comments of Daniel McNab

(And it also reintroduces the `Query` unsoundness, since that accesses no components anyway)

How is this issue different to https://github.com/bevyengine/bevy/issues/92? It appears to me to be covering the same ground. But I do agree, those formats are much nicer

I don't understand the question @Nilirad

Because I want this pr to be reviewable, not just a mess of `insert_bundlr->insert` renamings If this gets approved we can change them over in a follow up pr

The one time I try to use Github's merge-in-place UI, this is what it gives me :|

Can you explain the differences between this approach and https://github.com/bevyengine/bevy/pull/4216 ?

Frankly, I don't reallly like either option. This is consistent with wgpu, so it's probably fine; I certainly don't intend to block this. The fact that wgpu doesn't even expose...

I'm not sure I want users to be implementing `SystemParam` - at the very least I'd be reluctant to claim it's currently supported. I suppose unless/until we can work out...

A quick reading suggests that this is going to run into the same issue as the original (license locked so best not to look at the code I guess?): https://github.com/bevyengine/bevy/pull/1163

This issue occurs because when there are too many arguments, rustc and emcc use a response file to get around the windows command max length, and the parsing messes this...