Generic hierarchy propagation

Open mockersf opened this issue 1 year ago • 3 comments

Objective

There are two different hierarchy propagation for now: Transform/GlobalTransform and Visibility/ComputedVisibility
They slightly differ 😱

Make a generic system that do both
That can also be used by users if they want to add their own hierarchy propagation without handling all the details

Jul 31 '22 11:07 mockersf

Can you explain the differences between this approach and https://github.com/bevyengine/bevy/pull/4216 ?

Jul 31 '22 11:07 DJMcNab

Can you explain the differences between this approach and #4216 ?

Well the biggest difference is that I hadn't seen it before... Other than that, that PR is very similar.

#4216 is adding a extension on app to automatically add the systems, this one let users do it themselves
#4216 doesn't handle visibility (which wasn't propagated at the time) and is missing a few updates that were done since

Jul 31 '22 11:07 mockersf

Indeed it looks pretty similar to #4216 , but it not requiring the App extension thing seems like an improvement.

Jul 31 '22 12:07 superdump