Diego Guidi

can you post the stack trace? can be helpful to investigate what is the method actually throwing the exception

oh, understood. Maybe you can try to initialize the writer using an explicit Encoding as the third parameter and see if it works ``` new ShapefileDataWriter(path, geomFactory, Encoding.UTF8) // or...

@FObermaier `GetEncodingForCodePageIdentifier(437)` - French OEM - returns `null` this code shall work but actually the write of the features fail... ``` ShapefileDataWriter writer = new ShapefileDataWriter(path, geomFactory, Encoding.Default); writer.Header =...

@benabdelkrim you can do this to continue working 1. checkout nettopologysuite.io.shapefile code 1. add the nts.io.shapefile project to your solution 1. remove the nuget reference to nts.io.shapefile and add the...

> Additionally I made the the unit tests pass, there were a lot failing... do you mean, they fails in android? >If you don't mind, I'd rather commit my changes....

> but now that there are some, it makes sense to expose it makes sense to me, too

from [Shapefile specs, page 8-9](https://www.esri.com/content/dam/esrisites/sitecore-archive/Files/Pdfs/library/whitepapers/pdfs/shapefile.pdf) > The order of vertices or orientation for a ring indicates which side of the ring is the interior of the polygon... Vertices of rings...

The `shell_bad_ccw.shp` contains a single polygon, with: - a shell CCW-oriented (like a hole from ESRI specs) - a hole CW-oriented (like a shell from ESRI specs) The idea of...

> Does one polygon contain the other? In that case the result would be invalid. Yep, exactly (made explicit in the unit test). I see few different strategies: 1. let...

> I think the PR I pointed you to yesterday does it in a similar way ~~I will do a check, thanks~~ The code in the `WIP PR` [looks similar](https://github.com/coordinatus/NetTopologySuite.IO.Esri/blob/wip/redo-everything/src/NetTopologySuite.IO.Esri/Readers/ShapefilePolygonReader.cs#L82)...